[bug-mailutils] Compile error in 3.0

[Jordi Mallach]

Hi Sergey,

I'm going to try to get 3.0 in Debian stretch. I've come across this:

libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I../.. -I../..
-I../../include -I../../include -I/libmailutils -I. -Wdate-time
-D_FORTIFY_SOURCE=2 -DSYSCONFDIR=\"/etc\" -g -fdebug-prefix-
map=/build/mailutils-3.0=. -fstack-protector-strong -Wformat
-Werror=format-security -Wall -Wdeclaration-after-statement -ggdb -c
wordsplit.c  -fPIC -DPIC -o .libs/wordsplit.o
wordsplit.c: In function 'mu_wordsplit_perror':
wordsplit.c:2338:7: error: format not a string literal and no format
arguments [-Werror=format-security]
       wsp->ws_error (mu_wordsplit_strerror (wsp));
       ^~~
cc1: some warnings being treated as errors

It's the usual -Wformat-security type of bug, and I haven't seen a fix
in subsequent commits after the release.

Jordi

[Jordi Mallach]

Hi Sergey,

El dl 28 de 11 de 2016 a les 12:51 +0100, en/na Jordi Mallach va

Post by Jordi Mallach
Hi Sergey,
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I../.. -I../..
-I../../include -I../../include -I/libmailutils -I. -Wdate-time
-D_FORTIFY_SOURCE=2 -DSYSCONFDIR=\"/etc\" -g -fdebug-prefix-
map=/build/mailutils-3.0=. -fstack-protector-strong -Wformat
-Werror=format-security -Wall -Wdeclaration-after-statement -ggdb -c
wordsplit.c  -fPIC -DPIC -o .libs/wordsplit.o
wordsplit.c:2338:7: error: format not a string literal and no format
arguments [-Werror=format-security]
       wsp->ws_error (mu_wordsplit_strerror (wsp));
       ^~~
cc1: some warnings being treated as errors
It's the usual -Wformat-security type of bug, and I haven't seen a fix
in subsequent commits after the release.

Did you have a chance to test-compile using -Wformat-security? It's a
default GCC option in quite a few distributions these days.

Thanks!
Jordi

[Jordi Mallach]

Post by Jordi Mallach
Did you have a chance to test-compile using -Wformat-security? It's a
default GCC option in quite a few distributions these days.

The attached trivial patch fixes this.

Additionally, I'm attaching some spelling fixes.

[Jordi Mallach]

Post by Jordi Mallach
Additionally, I'm attaching some spelling fixes.
MAILVAR_TYPEMASK (mailvar_type_boolean),
- N_("allow to edit message headers while composing") },
+ N_("allow editting message headers while composing") },
{ { "emptystart", },
MAILVAR_TYPEMASK (mailvar_type_boolean),

One good way of looking like an idiot is introducing a typo in your
typo fix. Thanks to Neil R. Ormos who pointed this off-list. :)

Jordi

[Sergey Poznyakoff]

Post by Jordi Mallach
One good way of looking like an idiot is introducing a typo in your
typo fix. Thanks to Neil R. Ormos who pointed this off-list. :)

Never mind, Jordi. To err is human. Thanks for the patches!

Regards,
Sergey